Changeset 42389 for trunk/Ohana/src/tools/src/fits_insert.c

Timestamp:

Feb 8, 2023, 12:17:35 PM (3 years ago)

Author:

eugene

Message:

merge from eam_branches/ipp-20220316. fixes for more pendantic gcc; add opihi memory stats; string vector improvements; use named macros for fixed string lengths

Location:

trunk/Ohana

Files:

• . (modified) (1 prop)
• src/tools/src/fits_insert.c (modified) (4 diffs)

trunk/Ohana/src/tools/src/fits_insert.c

@@ -85 +85 @@
     p = gfits_header_field (&header, "COMMENT", Cnumber);
     if (p != (char *) NULL) {
-      strncpy (p, line, 80);
+      memcpy (p, line, 80); // do not use strncpy_nowarn: do NOT set last byte to NULL
     }
   }
@@ -108 +108 @@
     line[80] = 0;
     bzero (keyword, 10);
-    strncpy (keyword, line, 8);
+    strncpy_nowarn (keyword, line, 8);
     
     /* replace existing keywords, unless this is a COMMENT or HISTORY field */
@@ -114 +114 @@
       p = gfits_header_field (&header, keyword, 1);
       if (p != (char *) NULL) {
-        strncpy (p, line, 80);
+        strncpy_nowarn (p, line, 80);
         continue;
       }
@@ -151 +151 @@
         exit (1);
       }
-      strncpy (p+80, "END", 3);
+      memcpy (p+80, "END", 3); // do not use strncpy_nowarn, do NOT set last byte to NULL
       for (i = 3; i < 80; i++) { p[80+i] = ' '; }
     }
     /* insert the new line here */
-    strncpy (p, line, 80);
+    memcpy (p, line, 80); // do not use strncpy_nowarn, do NOT set last byte to NULL
   }
   if (fclose (f)) {