Changeset 42719 for branches/2dbias/psModules/src/detrend/pmOverscan.c

Timestamp:

Sep 13, 2024, 10:19:51 PM (22 months ago)

Author:

hgao

Message:

finetune overscan region and stats for reducing and smoothing overscan array/vector

File:

• branches/2dbias/psModules/src/detrend/pmOverscan.c (modified) (2 diffs)

branches/2dbias/psModules/src/detrend/pmOverscan.c

@@ -415 +415 @@
                 // Reduce the overscans
                 // XXX need to save 2 different chi-square values
-                psVector *yReduced = pmOverscanVector(&chi2, overscanOpts->primary, yscanPixels, false);
+                psVector *yReduced = pmOverscanVector(&chi2, overscanOpts->primary, yscanPixels, true);
                 psFree(yscanPixels);
                 if (!yReduced)
@@ -453 +453 @@
                         }
                         // Now normVector holds the sliced data; then, compute its robust mean
-                        psStatsOptions statistic = PS_STAT_CLIPPED_MEAN;
+                        psStatsOptions statistic = PS_STAT_ROBUST_MEDIAN;
                         psStats *stats = psStatsAlloc(statistic);
                         if (!psVectorStats(stats, normVector, NULL, NULL, 0))
                         {
-                                psError(PS_ERR_UNKNOWN, false, "failure to measure clipped mean as normalization of xReduced");
+                                psError(PS_ERR_UNKNOWN, false, "failure to measure robust median as the normalization of xReduced");
                                 psFree(stats);
                                 psFree(normVector);