Changeset 4326 for trunk/glueforge/templates/psdb/popobject.tt

Timestamp:

Jun 20, 2005, 2:54:17 PM (21 years ago)

Author:

jhoblitt

Message:

factor out intermediate value variables where it doesn't impact readability

File:

• trunk/glueforge/templates/psdb/popobject.tt (modified) (4 diffs)

trunk/glueforge/templates/psdb/popobject.tt

@@ -3 +3 @@
 [% object_name %] *[% namespace %]PopObject(psDB *dbh)
 {
-    bool            status;
-    [% indented(object_name, "*object") %];
 [% FOREACH item = columns -%]
 [% IF item.type == "STR" -%]
@@ -13 +11 @@
 [% END -%]
 
-    status = [% namespace %]Pop(dbh, 
+    if (![% namespace %]Pop(dbh, 
 [%- SET i = 0 -%]
 [% FOREACH item = columns -%]
@@ -22 +20 @@
 &[% item.name -%]
 [% END -%]
-[% END %]);
-    if (!status) {
+[% END %])) {
         // psError(); something bad happened
         return NULL;
     }
 
-    object = [% object_name %]Alloc(
+    return [% object_name %]Alloc(
 [%- SET i = 0 -%]
 [% FOREACH item = columns -%]
@@ -34 +31 @@
 [% item.name %]
 [%- END -%]);
-
-    return object;
 }