Changeset 4705 for trunk/Ohana/src/opihi/pantasks/JobOps.c

Timestamp:

Aug 3, 2005, 5:50:08 PM (21 years ago)

Author:

eugene

Message:

psched / pscontrol / pclient dev work

File:

• trunk/Ohana/src/opihi/pantasks/JobOps.c (modified) (5 diffs)

trunk/Ohana/src/opihi/pantasks/JobOps.c

@@ -50 +50 @@
   int i;
 
+  fprintf (stderr, "\n");
   if (Njobs == 0) {
-    fprintf (stderr, "no defined jobs\n");
+    fprintf (stderr, " no defined jobs\n");
     return;
   }
 
+  fprintf (stderr, " Jobs\n");
   for (i = 0; i < Njobs; i++) {
-    fprintf (stderr, "%d: %-15s %5d %20s (%lx)\n", Njobs, jobs[i][0].task[0].name, jobs[i][0].JobID, jobs[i][0].argv[0], (long) jobs[i][0].argv);
+    fprintf (stderr, " %d: %-15s %5d %20s (%lx)\n", Njobs, jobs[i][0].task[0].name, jobs[i][0].JobID, jobs[i][0].argv[0], (long) jobs[i][0].argv);
   }
   return;
@@ -76 +78 @@
   }
 
-  /* we need our own copy of task[0].argv 
-   *  argc is the number of valid args, like the usual command line.
-   *  we allocate one extra element, with value 0 to be passed to execvp
+  /* we need our own copy of task[0].argv argc is the number of valid args, like the usual command line.  we
+   *  allocate one extra element, with value 0 to be passed to execvp
    */
   job[0].argc = task[0].argc;
@@ -87 +88 @@
   job[0].argv[i] = 0;
 
-  /* other data from the task is needed by the job 
-     we carry a pointer back to the task.  this means we 
-     cannot modify the task once a job is created, or the changes will 
-     be applied to the existing jobs */
+  /* Other data from the task is needed by the job. We carry a pointer back to the task.  Changes to an
+     executing task are applied to the existing jobs (exit macros, poll_period, timeout) */
 
   job[0].task = task;
   
-  /* if we decide we need to be able to dynamically set task qualities
-     (like host, timeouts, etc), the we will need to have matched 
-     entries to these quantites in the job structure */
+  /* if we decide we need to be able to dynamically set task qualities (like host, timeouts, etc), the we will
+     need to have matched entries to these quantites in the job structure */
 
   jobs[Njobs] = job;
@@ -122 +120 @@
 }
 
-/** are we deleting the active job?? **/
+/* delete the job from the job list & adjust ActiveJob counter */
 int DeleteJob (Job *job) {
 
@@ -140 +138 @@
 
   FreeJob (jobs[Nm]);
-  for (i = Nm + 1; i < Njobs; i++)
-    jobs[i - 1] = jobs[i];
+  for (i = Nm; i < Njobs - 1; i++) {
+    jobs[i] = jobs[i + 1];
+  }
   Njobs --;