psImageRebin doesn't know of a mask, but should it?

[robert.desonia@…]

Since this function is doing statistics, part of me doth thinks it should have a
mask like psImageStats.

Do you see not needing a mask for this function? I don't know if you would want
to use a bad pixel in the rebinning, for instance.

(Since I'm using the psVectorStats under the hood, it is not too hard to add
this in as it handles the mask checking)

[eugene]

you are right. any of these functions (like psImageCut and psImageRebin) which
apply a particular statistic need to have the mask and maskVal passed in as well.
I'll add it to the SDRS like this:

psVector *psImageSlice(psVector *out, const psImage *input,

const psImage *restrict mask,
unsigned int maskVal,
int x, int y, int nx, int ny,
psImageCutDirection direction, const psStats *stats);

and

psVector *psImageCut(psVector *out, const psImage *input,

const psImage *restrict mask,
unsigned int maskVal,
float xs, float ys, float xe, float ye,
float dw, const psStats *stats);

and

psVector *psImageRadialCut(psVector *out, const psImage *input,

const psImage *restrict mask,
unsigned int maskVal,
float x, float y,
const psVector *radii, const psStats *stats);

and

psImage *psImageRebin(psImage *out, const psImage *in,

const psImage *restrict mask,
unsigned int maskVal,
int scale, const psStats *stats);

and in any of these functions, mask may be NULL, in which case it is ignored.

[Paul Price]

These have been added to the SDRS (apart from the "restrict"s, which have been
dropped).