IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 22 years ago

Closed 22 years ago

Last modified 22 years ago

#138 closed enhancement (fixed)

Should a consistant means of specifying an image region be used?

Reported by: robert.desonia@… Owned by: Paul Price
Priority: high Milestone:
Component: PSLib SDRS Version: unspecified
Severity: minor Keywords:
Cc:

Description

I noticed that functions like psImageSubset specifies a region using a
lower-left corner (x0,y0) and size nx & ny. Functions like psImageTrim,
however, specifies a region using a lower-left corner (x0,y0) and a
upper-right corner (x1,y1). psImageSubSection basically uses this second
method, though the order of the elements are different ( [x0:x1,y0:y1] versus
x0,y0 - x1,y1 ).

A single method of describing an image region probably should be adopted for
the library.

-rdd

Change History (4)

comment:1 by eugene, 22 years ago

Owner: changed from eugene to Paul Price

the concensus was (x0,y0) - (x1,y1) where (x1,y1) is exclusive allowing the use
of (0,0) - (Nx,Ny). the particular string parsing function is needed since this
is a standard FITS representation of a region.

APIs need to be inspected for consistency.

comment:2 by Paul Price, 22 years ago

Resolution: fixed
Status: newclosed

psImageSubset, psImageTrim, psImageReadSection, psImageSlice are the ones that
require image sections to be defined. Each has been brought into line with the
standard x0,y0,x1,y1 region specification. Note that x1,y1 are exclusive, and
may be negative (in which case they are relative to the particular dimension).

comment:3 by Paul Price, 22 years ago

Keywords: VERIFIED added

Should be fixed in SDRS-07 and ADD-06 (7 September 2004).

comment:4 by Paul Price, 22 years ago

Keywords: VERIFIED removed
Note: See TracTickets for help on using tickets.