Opened 15 years ago
#1474 new defect
What is CAL_PSF_MAG_SIG supposed to mean?
| Reported by: | Michael Wood-Vasey | Owned by: | magnier |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | psphot | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
I've been assuming that CAL_PSF_MAG_SIG is supposed to be the uncertainty in the total measurement of PSF_MAG, i.e. the equivalent of PSF_INST_MAG_SIG (most likely should be the same as PSF_INST_MAG_SIG). But I finally looked at the code and I see that it's defined as the uncertainty in the _zeropoint_calibration_, not the uncertainty in the measurement.
psMetadataAdd (row, PS_LIST_TAIL, "CAL_PSF_MAG_SIG", PS_DATA_F32, "measured scatter of zero point calibration", zeroptErr);
I would bet that I am not alone in my confusion. If CAL_PSF_MAG_SIG is supposed to be the zeropoint calibration uncertainty, can we rename it to something else, e.g., CAL_PSF_ZPT_SIG, to be less confusing?
If it is supposed to just be the PSF_INST_MAG_SIG then it could easily just be set to that, but I appreciate that one would like to avoid redundancy in files.
