psTraceReset() doesn't free memory

[rhl@…]

The SDRS doesn't state explicitly that it should, but my initial implementation did. George noted that
there was no API to free all the psTrace memory and added psTraceFree() -- but it makes sense to
use psTraceReset as none of that memory is useful after the system's been reset.

In this case, psTraceReset() (which isn't in the SDRS) should be removed.

rel2_2

[robert.desonia@…]

Is this really a bug on the code or the requirement specification? The SDRS
states "a function void psTraceReset(void) will set all trace levels to 0."
This sounds like what was implemented for that function.

I think a change in the SDRS might need to be done here.

-rdd

Oh, and the last thing in the initial report was "In this case, psTraceReset()
(which isn't in the SDRS) should be removed." Did you mean psTraceFree should
be removed?

[robert.desonia@…]

Hey, Lupton found rel2_2 - how clever of him! I really didn't advertise its
existence.

[gusciora@…]

I removed psTraceFree(), and coded psTraceReset() to free all components in the
tree and set cRoot to NULL.

[gusciora@…]

The SDR was never modified to conform to the behavior requested in this bug.

[Eric.VanAlst@…]

Is this requirement of freeing memory going to be add to SDR for function
psTraceReset?

[Paul Price]

Fixed the SDRS:

In addition, a function \code{bool psTraceReset(void)} will free memory used by
\code{psTrace} functions, effectively resetting all trace levels to 0.

[Paul Price]

Verified.