IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 22 years ago

Closed 22 years ago

Last modified 22 years ago

#151 closed defect (worksforme)

p_psCroot in psTrace.c is static, but has a (private) external name

Reported by: rhl@… Owned by: Paul Price
Priority: lowest Milestone:
Component: sys Version: unspecified
Severity: trivial Keywords:
Cc:

Description

The code conventions state that a p_ps or ps prefix should be used if and only if a name is globally
visible; this is violated for p_psCroot (and p_psTraceFP)

static p_psComponent* p_psCroot = NULL; The root of the trace component

rel2_2

Change History (2)

comment:1 by gusciora@…, 22 years ago

Resolution: worksforme
Status: newclosed

Variable names have been changed to cRoot and traceFP.

comment:2 by Paul Price, 22 years ago

To clarify, added to the code conventions document, as suggested by RHL:

A name (whether of a variable, a function, or a type) shall start \code{ps} (or
\code{p_ps}) if and only if it is visible at global scope. The distinction is
that \code{p_ps} names are not part of the documented APIs, but need to be
exposed for some reason.

Note: See TracTickets for help on using tickets.