#229 closed defect (fixed)
psKernelGenerate with varying sized vectors
| Reported by: | Owned by: | Paul Price | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | PSLib SDRS | Version: | unspecified |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Upon studying the sample code from Tonry, I think the requirement that "If the
vectors are not all the same number of elements, then the function shall
generate a warning shall be generated (sic), following which, the longer vector
[shall be] trimmed to length of the shorter, and the function shall continue"
doesn't make sense.
Tonry's code assumes that shifts are relative to the last shift, which makes
sense as the image is assumably the output of the last shift. However, if one
trims data to the shortest of the vectors, the assumption that the image is a
representative of the last shift is lost, I believe. It might be better to just
error in this case.
-rdd
Change History (3)
comment:1 by , 22 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 22 years ago
| Keywords: | VERIFIED added |
|---|
Closing subsequent to release of SDRS-08, ADD-07.
comment:3 by , 22 years ago
| Keywords: | VERIFIED removed |
|---|

Agreed. SDRS now reads:
If the vectors are not all of the same number of elements, then the
function shall generate an error and return \code{NULL}.