`make` && `make distcheck` fail because of hardwired paths

[jhoblitt]

There seems to be some hardwired paths in psModules. make distcheck always
fails and make will fail unless ../psLib exists.

from `make
--
--Making all in src
make[1]: Entering directory `/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/src'
make all-am
make[2]: Entering directory `/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/src'
if gcc -DHAVE_CONFIG_H -I. -I. -I. -g -O2 -std=gnu99 -I/usr/local/include
-DBUILD_PSDB -Wall -Werror -MT pmFlatField.o -MD -MP -MF ".deps/pmFlatField.Tpo"
-c -o pmFlatField.o pmFlatField.c; \
then mv -f ".deps/pmFlatField.Tpo" ".deps/pmFlatField.Po"; else rm -f
".deps/pmFlatField.Tpo"; exit 1; fi
if gcc -DHAVE_CONFIG_H -I. -I. -I. -g -O2 -std=gnu99 -I/usr/local/include
-DBUILD_PSDB -Wall -Werror -MT pmMaskBadPixels.o -MD -MP -MF
".deps/pmMaskBadPixels.Tpo" -c -o pmMaskBadPixels.o pmMaskBadPixels.c; \
then mv -f ".deps/pmMaskBadPixels.Tpo" ".deps/pmMaskBadPixels.Po"; else rm -f
".deps/pmMaskBadPixels.Tpo"; exit 1; fi
if gcc -DHAVE_CONFIG_H -I. -I. -I. -g -O2 -std=gnu99 -I/usr/local/include
-DBUILD_PSDB -Wall -Werror -MT pmSubtractBias.o -MD -MP -MF
".deps/pmSubtractBias.Tpo" -c -o pmSubtractBias.o pmSubtractBias.c; \
then mv -f ".deps/pmSubtractBias.Tpo" ".deps/pmSubtractBias.Po"; else rm -f
".deps/pmSubtractBias.Tpo"; exit 1; fi
In file included from pmSubtractBias.c:23:
pmSubtractBias.h:26:51: ../../psLib/src/dataManip/psConstants.h: No such file or
directory
make[2]: * [pmSubtractBias.o] Error 1
make[2]: Leaving directory `/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/src'
make[1]: * [all] Error 2
make[1]: Leaving directory `/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/src'
make: * [all-recursive] Error 1

from make distcheck
--
if gcc -DHAVE_CONFIG_H -I. -I../../src -I. -g -O2 -std=gnu99
-I/usr/local/include -DBUILD_PSDB -Wall -Werror -MT pmSubtractBias.o -MD -MP -MF
".deps/pmSubtractBias.Tpo" -c -o pmSubtractBias.o ../../src/pmSubtractBias.c; \
then mv -f ".deps/pmSubtractBias.Tpo" ".deps/pmSubtractBias.Po"; else rm -f
".deps/pmSubtractBias.Tpo"; exit 1; fi
In file included from ../../src/pmSubtractBias.c:23:
../../src/pmSubtractBias.h:26:51: ../../psLib/src/dataManip/psConstants.h: No
such file or directory
make[3]: * [pmSubtractBias.o] Error 1
make[3]: Leaving directory
`/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/psModule-0.5.0/_build/src'
make[2]: * [all] Error 2
make[2]: Leaving directory
`/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/psModule-0.5.0/_build/src'
make[1]: * [all-recursive] Error 1
make[1]: Leaving directory
`/home/moanui/jhoblitt/pscvs/datasys/IPP/psModule/psModule-0.5.0/_build'
make: * [distcheck] Error 2

[robert.desonia@…]

This bug will appear George's performance review, I think. :-) Considered
caning, but management now frowns on that.

The fix is in CVS. Basically, the psConstants.h include line was deleted (that
header is in pslib.h already).

-rdd

[jhoblitt]

I can confirm that psModule HEAD now builds as expected. Please make a rel5_1
tag that includes this fix.