long double warning caused by gsl on OSX

[jhoblitt]

I'm not sure why gcc isn't complaining about this on any other platform.

A kludgy solution is to set CFLAG="-Wno-long-double" (which is picked up by
configure). I'm not sure exactly what the long term solution should be. The
idea of just globaly setting "-Wno-long-double isn't very appealing to me.
Perhaps the best solution is to disable the warning just for psMatrix.c.

--
In file included from
/Users/jhoblitt/prefix/include/gsl/gsl_matrix_complex_long_double.h:26,

from /Users/jhoblitt/prefix/include/gsl/gsl_matrix.h:4,
from psMatrix.c:33:

/Users/jhoblitt/prefix/include/gsl/gsl_complex.h:39: warning: use of `long
double' type; its size may change in a future release
/Users/jhoblitt/prefix/include/gsl/gsl_complex.h:39: warning: (Long double usage
is reported only once for each file.
/Users/jhoblitt/prefix/include/gsl/gsl_complex.h:39: warning: To disable this
warning, use -Wno-long-double.)
make[4]: * [psMatrix.lo] Error 1
make[3]: * [all] Error 2
make[2]: * [all-recursive] Error 1
make[1]: * [all] Error 2
make: * [all-recursive] Error 1
--

[robert.desonia@…]

Which version of GSL/gcc do you have? We see no such problem on our Mac with
GSL 1.4 and gcc 3.3.

pippin:~/psLib desonia$ gsl-config --version
1.4

pippin:~/psLib desonia$ gcc --version
gcc (GCC) 3.3 20030304 (Apple Computer, Inc. build 1495)
Copyright (C) 2002 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

pippin:~/psLib desonia$ hostinfo
Mach kernel version:

Darwin Kernel Version 7.9.0:

Wed Mar 30 20:11:17 PST 2005; root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC

Kernel configured for up to 2 processors.
2 processors are physically available.
Processor type: ppc970 (PowerPC 970)
Processors active: 0 1
Primary memory available: 1024.00 megabytes.
Default processor set: 58 tasks, 142 threads, 2 processors
Load average: 0.00, Mach factor: 1.99

pippin:~/psLib desonia$ make
...
source='psMatrix.c' object='psMatrix.lo' libtool=yes \
depfile='.deps/psMatrix.Plo' tmpdepfile='.deps/psMatrix.TPlo' \
depmode=gcc3 /bin/sh ../../depcomp \
/bin/sh ../../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../../src
-I../../src/astronomy -I../../src/collections -I../../src/fileUtils
-I../../src/image -I../../src/sysUtils -std=c99 -O0 -g
-I/usr/local/include -I/Users/evanalst/libxml2/include/libxml2 -Wall -Werror -c
-o psMatrix.lo test -f 'psMatrix.c' || echo './'psMatrix.c

gcc -DHAVE_CONFIG_H -I. -I. -I../../src -I../../src/astronomy

-I../../src/collections -I../../src/fileUtils -I../../src/image
-I../../src/sysUtils -std=c99 -O0 -g -I/usr/local/include
-I/Users/evanalst/libxml2/include/libxml2 -Wall -Werror -c psMatrix.c -MT
psMatrix.lo -MD -MP -MF .deps/psMatrix.TPlo -fno-common -DPIC -o .libs/psMatrix.o
...

[robert.desonia@…]

Went and got latest GSL, and now I can duplicate it. I'll look into it.

-rdd

[jhoblitt]

The error has been confirmed on two different OSX systems here as well.

$ gsl-config --version
1.6
$ gcc --version
gcc (GCC) 3.3 20030304 (Apple Computer, Inc. build 1495)
Copyright (C) 2002 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[robert.desonia@…]

Added logic to configure.ac to check if on OSX, and if so add '-lg2c' to FLIBS
(only if g2c is found) and '-Wno-long-double' to CFLAGS.

Fix is in CVS HEAD.

-rdd