#385 closed enhancement (fixed)
changes to build scripts / extraneous build files
| Reported by: | jhoblitt | Owned by: | |
|---|---|---|---|
| Priority: | highest | Milestone: | |
| Component: | sys | Version: | unspecified |
| Severity: | minor | Keywords: | |
| Cc: |
Description
configure.ac does not require a specific version or check to see if it's running
in the proper directory, nor is automake's maintainer mode enabled.
Additionaly, there is no autogen.sh as is now the standard for
Gnomne/freedesktop.org projects and one of our build tools require it. This
file would act as a replacement for "Makefile.cvs" but there is no reason not to
keep both files around for the time being.
There are currently several autogenerated files floating around in CVS
(install-sh, config.guess, etc.) that can (should) be removed.
Attachments (1)
Change History (16)
by , 21 years ago
| Attachment: | pslib-0.6-build_tidy.patch added |
|---|
comment:1 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
applied patch, verified things work (just had to modify Makefile.cvs to have
automake install the deleted files) and checked it into cvs HEAD.
comment:2 by , 21 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I don't think that autogen.sh got checked in.
comment:3 by , 21 years ago
| Status: | reopened → assigned |
|---|
I checked it in, but it doesn't work on my machine (complains about my aclocal
version being not 1.6 -- it is 1.9.3).
comment:4 by , 21 years ago
It's safe to remove the revsion req. as autoconf is now checking the automake
revision. That was in there to make sur automake and aclocal would also be at
the same revision.
Just remove the '-1.6' suffix from aclocal and automake.
comment:7 by , 21 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Line 8 of the configure.ac was changed from
AM_CONFIG_HEADER(src/config.h)
to
AC_CONFIG_HEADERS([src/config.h])
which was not part of the attached patch and has caused a build error on at
least one host. What was the reason for this change and is there any reason
that it can't be reverted?
comment:8 by , 21 years ago
I've traced the build error to just automake 1.6 requiring AM_CONFIG_HEADER.
automake 1.7, 1.8, & 1.9 don't complain that AM_CONFIG_HEADER is missing but
never the less it should be used in place of AC_CONFIG_HEADERS when automake is
being used.
comment:9 by , 21 years ago
I just noticed that autogen.sh isn't executable by default. This is really
annoying. Can you run chmod a+x autogen.sh,v on the script in the repository?
comment:10 by , 21 years ago
| Priority: | high → highest |
|---|---|
| Severity: | normal → enhancement |
comment:11 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Change AC_CONFIG_HEADERS to AC_CONFIG_HEADER in configure.ac
chmod'ed autogen.sh,v in the cvs tree.
- chmoding the file and checking it in didn't work (CVS didn't want to set
the executable flag, I guess).
-rdd
comment:12 by , 21 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
automake 1.6 is still broken as it needs AM_CONFIG_HEADER, not AC_CONFIG_HEADERS
or AC_CONFIG_HEADER. Please change it to AM_CONFIG_HEADER or explain to me why
you want to use AM_CONFIG_HEADER* in it's place.
comment:14 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
changed AC_CONFIG_HEADER to AM_CONFIG_HEADER.
patch to add autogen.sh, tidy configure.ac, and remove unneeded files