#415 closed defect (fixed)
death to Fortran
| Reported by: | jhoblitt | Owned by: | |
|---|---|---|---|
| Priority: | highest | Milestone: | |
| Component: | astro | Version: | unspecified |
| Severity: | major | Keywords: | |
| Cc: |
Description
src/astronomy/psAstrometry.c is including slalib.h and using these functions:
slaAirmas(), slaAoppa(), slaAopqk(), slaOapqk(). All dependencies on Fortran
code are supposed to be removed during cycle 6.
psAstrometry's dependency on these Fortran functions should be removed by
reimplementing them in C. slalib.h along with the 18 '.f' files under
src/astronomy/ should be removed and the build system updated as appropriate
(removing FLIBS from configure.ac, etc.).
Change History (7)
comment:1 by , 21 years ago
comment:2 by , 21 years ago
| Severity: | enhancement → major |
|---|---|
| Status: | new → assigned |
comment:3 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I removed all fortran code. This created issues with the TP<->Sky
transformations and some issues with psGrommit, but those seem to be in flux
right now anyway (many TBDs in the SDRS version I have).
Once the specification gets more solid, i.e., no more TBDs, I'll go back and
finish the replacement implementation.
-rdd
comment:4 by , 21 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Thanks. FLIBS can be removed from configure.ac as well.
Index: configure.ac
===================================================================
RCS file: /cvsroot/pan-starrs/datasys/IPP/psLib/configure.ac,v
retrieving revision 1.33
diff -u -r1.33 configure.ac
--- configure.ac 8 Jun 2005 02:38:02 -0000 1.33
+++ configure.ac 8 Jun 2005 21:17:51 -0000
@@ -28,7 +28,6 @@
case $host in
*-apple-darwin*)
CFLAGS="${CFLAGS=} -Wno-long-double"
- FLIBS="${FLIBS} -lg2c"
;;
esac
@@ -46,7 +45,6 @@
dnl Setup the info for psLib for pkg-config
PSLIB_CFLAGS="-I${includedir}"
-PSLIB_LIBS="${FLIBS=}"
dnl check for standard language functionality
AC_HEADER_STDC
comment:5 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Oops, missed that. Thanks.
comment:6 by , 21 years ago
| Keywords: | VERIFIED added |
|---|

just to clarify this: the EOC and other astrometry functions in sections 6.4 and
6.5 replace the SLALIB functions. even if those are not done for cycle 6, we
should still drop the fortan/slalib dependency.