psDBCleanup won't take !dbh

[Paul Price]

I suggest that psDBCleanup should behave like psFree, in that if it is passed a
NULL database handle (dbh), it should quietly perform no action. The current
implementation produces a SEGV if passed a NULL.

[jhoblitt]

It looks like this change has already been made:

1.22 (evanalst 15-Jun-05): Check if argument dbh is NULL
1.22 (evanalst 15-Jun-05): if(dbh == NULL) {
1.22 (evanalst 15-Jun-05): psError(PS_ERR_BAD_PARAMETER_TYPE, true,
1.22 (evanalst 15-Jun-05): PS_ERRORTEXT_psDB_INVALID_PSDB);
1.22 (evanalst 15-Jun-05): } else {

Can this bug be closed?

[Paul Price]

I guess. It's not the behaviour I suggested, but it works.

[jhoblitt]

It's probably fine for the time being as it'll have to be changed yet again to
make it thread safe / not needlessly dump and regenerate the lookup tables if
you have more then one database connection open.

[Eric.VanAlst@…]

Current implementation generates an error.

[Paul Price]

Bug has been resolved.... closing.

[Paul Price]

Bugs have been fixed... closing.