#499 closed defect (fixed)
Return types
| Reported by: | Owned by: | Paul Price | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | PSLib SDRS | Version: | unspecified |
| Severity: | normal | Keywords: | IPP-doc |
| Cc: |
Description
As far I can tell, the following functions should return a bool instead of int,
int psXMLDocToFD(const psXMLDoc *doc, int fd)
int psXMLDocToMem(const psXMLDoc *doc, char *buffer)
int psXMLDocToFile(const psXMLDoc *doc, const char *filename)
I can't see any reason for these to return int's, so if this doesn't change,
please elaborate on what that int represents. I could also see void be
appropriate.
Change History (4)
comment:1 by , 21 years ago
| bug_group: | PSLib? → IPP-doc? |
|---|---|
| Component: | xml → PSLib SDRS |
| Keywords: | IPP-doc added; PSLib removed |
| product: | PSLib → IPP-doc |
comment:2 by , 21 years ago
| Owner: | changed from to |
|---|
comment:3 by , 21 years ago
comment:4 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Agreed --- let's make them bool.
bool psXMLDocToFile(const psXMLDoc *doc, const char *filename);
bool psXMLDocToMem(const psXMLDoc *doc, char *buffer);
bool psXMLDocToFD(const psXMLDoc *doc, int fd);
Note:
See TracTickets
for help on using tickets.
Actually, I think that the return values should be bool to indicate success/failure.