#536 closed defect (fixed)
psTime and Julian dates
| Reported by: | Paul Price | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | astro | Version: | 0.7.0 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
psTimeToMJD does not check what time type is in use. The ADD specifies TAI.
Also affects:
psTimeToJD
psTimeFromMJD
psTimeFromJD
Change History (13)
comment:1 by , 21 years ago
| Owner: | changed from to |
|---|
comment:2 by , 21 years ago
comment:3 by , 21 years ago
Yes, psTimeToJD and psTimeToMJD should convert to TAI first if necessary.
I must have added the psTimeFrom* functions because I was looking at an old API.
comment:4 by , 21 years ago
| Owner: | changed from to |
|---|
I'm really not sure this bug is valid. I've added a line before the returns in
ToMJD and ToJD to set the time type to TAI. Otherwise, the time type seems
completely irrelevant in these functions to me.
comment:5 by , 21 years ago
Before a psTime can be converted to an MJD, it must first be converted to TAI.
comment:6 by , 21 years ago
actually, disregard my previous statement about changing the time type before
return. took that out.
comment:7 by , 21 years ago
| Status: | new → assigned |
|---|
comment:8 by , 21 years ago
| Status: | assigned → new |
|---|
comment:9 by , 20 years ago
| Owner: | changed from to |
|---|
comment:10 by , 20 years ago
| Owner: | changed from to |
|---|
comment:11 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Ok, this one was a little harder than expected but i believe i've nailed it now.
Fixed the problem and stopped the seg faulting that was consequently occurring
from time conversions.
I'm not sure exactly what is desired here...
I assume you want a check on the TimeType and conversion if necessary for the
"To" functions that are listed.
As for the the "From" functions, I believe they already convert to TAI.