IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 21 years ago

Closed 21 years ago

Last modified 21 years ago

#544 closed defect (fixed)

psImageRow/Col argument

Reported by: David.Robbins@… Owned by: Paul Price
Priority: high Milestone:
Component: PSLib SDRS Version: unspecified
Severity: normal Keywords:
Cc:

Description

these functions use a third argument of psU32 to specify the size of a row or
column to be copied into a psVector. However, the image struct uses int's for
numCols and numRows so there is a size difference that could potentially cause
problems. I suggest changing these arguments to psS32, int, or perhaps a
smaller psU if signed-ness is an issue.
see SDRS p73.

Change History (2)

comment:1 by David.Robbins@…, 21 years ago

Oops. I made a mistake. The argument is still valid except that I should have
said that the psU32 is used for the row/col number, not the size.

comment:2 by Paul Price, 21 years ago

Resolution: fixed
Status: newclosed

Changed them to int. As usual, a negative row or column implies index from the end.

psVector *psImageRow(psVector *out,

const psImage *input,
int row);

psVector *psImageCol(psVector *out,

const psImage *input,
int column);

Note: See TracTickets for help on using tickets.