#561 closed defect (invalid)
psSphere Offset functions - units
| Reported by: | Owned by: | Paul Price | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | PSLib SDRS | Version: | unspecified |
| Severity: | normal | Keywords: | |
| Cc: |
Description
The sphere offset functions are currently defined as using a psSphereOffsetUnit
argument for specifying which type of units a psSphere contains. We think this
is something that should be removed since all other sphere operations only use
radians. There are functions to convert between the units and have or can be
made accessible to the user, but I feel it is inconsistent and dangerous to
allow the user to specify a psSphere in anything other than radians. In this
case, the Get function also allows a psSphere to be returned in different units,
which is unnecessary since it can't be used again until it is converted back to
radians.
Note:
See TracTickets
for help on using tickets.
The SDRS gives the reasoning in the subsection on "Angles":
To maintain consistency throughout the library, angles shall be
specified in radians. In a small number of cases which we expect will
be used heavily (i.e., \code{psSphereOffset} and trigonometric
operations on vectors), the unit may be specified, which provides
convenience to the user.
Let's leave it as it is.