IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 21 years ago

Closed 20 years ago

Last modified 20 years ago

#603 closed defect (fixed)

psVectorClipFitPolynomial1D inverted test on stats->min,max

Reported by: eugene Owned by: gusciora@…
Priority: high Milestone:
Component: math Version: unspecified
Severity: normal Keywords:
Cc:

Description

in the eam_rel8_b1 version of psMinimize.c, there is a bug in
psVectorClipFitPolynomial1D: the tests for stats->min and stats->max (to see if
they have been set) chooses the wrong option: if (isfinite(stats->min)) then
the code should use the value of stats->min not the value of stats->clipSigma.
The same error occurs for stats->max.

I've implemented the fix in eam_rel8_b2

Change History (5)

comment:1 by robert.desonia@…, 21 years ago

Status: newassigned

joined eam_rel8_b1 and eam_rel8_b2 into the CVS main trunk. This caused many problems in psCoord, as
George also made changes to this in response to bugs filed recently. Can you tell me if the code in your
branch fixed these issues already?

comment:2 by eugene, 21 years ago

the changes I made fixed the linear transform inversion, and it looks like
george's code fixes the same matrix inversion bug. my code also fixed psProject
and psDeproject, which the 1.93 version does not address. On the other hand,
George added in some ASSERT and other critical tests, but I suppose those don't
cause conflicts?

comment:3 by eugene, 21 years ago

the primary bug here (stats->min, stats->max) was still there in rel9_0

I've fixed it in eam_rel9_b0

comment:4 by robert.desonia@…, 20 years ago

Owner: changed from robert.desonia@… to gusciora@…
Status: assignednew

comment:5 by gusciora@…, 20 years ago

Resolution: fixed
Status: newclosed

This code is fixed (current CVS tree).

Note: See TracTickets for help on using tickets.