Opened 21 years ago
Closed 21 years ago
#616 closed defect (fixed)
psLibUtils.[ch], psModulesUtils.[ch] should not be included
| Reported by: | eugene | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | objects | Version: | 0.9.0 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
these four files (psLibUtils.[ch], psModulesUtils.[ch]) were supporting code in
psphot that should not be merged into psModule. the psLibUtils functions are
essentially all in psLib already, or their equivalents. the psModulesUtils
functions are not sufficiently clear to go in.
I've dropped them in the Makefile.am for eam_rel9_b0
Change History (4)
comment:1 by , 21 years ago
comment:2 by , 21 years ago
I see, I didn't catch that. OK, let's move it to pmObjects.c and make it
publically visible. The API for that one is fine.
comment:3 by , 21 years ago
| blocked: | → 628 |
|---|
comment:4 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Done. Only issue is that psObjects.c is now approaching 2000 lines and probably needs to be split. Any
suggestions on where to split that file?
-rdd
Note:
See TracTickets
for help on using tickets.
If I remove psModulesUtils.c, I get an undefined reference for pmSourcePhotometry from pmPSFtry.c. Shall
I move pmSourcePhotometry to pmPSFtry.c as a static function?