pmAstromRadiusMatch sorts the input lists and returns the indices of the sorted lists

[rhl@…]

pmAstromRadiusMatch sorts the input lists and returns the indices of
the _sorted_ lists, not the original ones.

This is not what a user wants! In general, the input lists correspond to some
other lists [e.g. of pmSources], and it's the pmSources that the user wants
to match up.

As an implementation issue, the search appears to be linear (not bisection) even though the lists are
sorted in x

[gusciora@…]

Feel free to reassign it to me if you want us to work on this.

[rhl@…]

Gene points out that my initial PR was pretty sketchy...

My application was to match a set of pmSources. Unforutunately, the match routines
use pmAstromObj. I can create a list of pmAstromObj from pmSource (although I'd
rather not have to), and then call the match routines (e.g. pmAstromGridMatch and
pmAstromRadiusMatch). These return a match struct that gives me the indices into
the pmAstromObj lists and I'd like to be able to use these indices to match up the
initial pmSource lists.

Unfortunately, the match routines sort their lists of pmAstromObj, and the returned
match struct refers to these SORTED lists, which bear no relation to my pmSource
lists.

[rhl@…]

Fixed in pmAstrometryObjects.c revision: 1.10. The functions pmAstromRadiusMatch/
pmAstromRadiusMatchChip no longer modify their input lists (and the lists are thus
declared const)