psBitSet testing
(a) SVD p21 says it checks that a set of a non-multile of 8 bits can be
allocated, but this is not done:
price@mithrandir:/home/mithrandir/price/psLib/test/collections>grep
psBitSetAlloc *.c
tst_psBitSet_01.c: psBitSet* bs = psBitSetAlloc(24);
tst_psBitSet_02.c: psBitSet* bs1 = psBitSetAlloc(24);
tst_psBitSet_02.c: psBitSet* bs2 = psBitSetAlloc(24);
tst_psBitSet_02.c: psBitSet* outbs = psBitSetAlloc(24);
tst_psBitSet_03.c: psBitSet* bs1 = psBitSetAlloc(24);
tst_psBitSet_03.c: psBitSet* bs2 = psBitSetAlloc(24);
tst_psBitSet_03.c: psBitSet* outbs = psBitSetAlloc(24);
tst_psBitSet_04.c: psBitSet* bs1 = psBitSetAlloc(24);
tst_psBitSet_04.c: psBitSet* bs2 = psBitSetAlloc(24);
tst_psBitSet_04.c: psBitSet* outbs = psBitSetAlloc(24);
tst_psBitSet_05.c: psBitSet* bs1 = psBitSetAlloc(24);
tst_psBitSet_05.c: psBitSet* bs2 = psBitSetAlloc(40);
tst_psBitSet_05.c: psBitSet* outbs = psBitSetAlloc(24);
tst_psBitSet_06.c: psBitSet* bs1 = psBitSetAlloc(24);
tst_psBitSet_06.c: psBitSet* bs2 = psBitSetAlloc(24);
tst_psBitSet_06.c: psBitSet* outbs = psBitSetAlloc(24);
tst_psBitSet_06.c: psBitSetAlloc(-4);
(b) psBitSet0[234]: SVD says 0xFF AND|OR|XOR 0x55, but program is in effect
testing 0xFF AND 0xFF, which is not testing the full range of functionality. I
think we would like to run the operations: eg., 0x3 AND|OR|XOR 0x5 (so that we
get each combination of 0 and 1 in the operations).
Change History
(5)
| Owner: |
changed from robert.desonia@… to calvin.harman@…
|
| Owner: |
changed from calvin.harman@… to Paul Price
|
| Status: |
assigned → new
|
| Resolution: |
→ fixed
|
| Status: |
new → closed
|
I added another psBitset test driver (tst_psBitSet07.c) to test for items a and
b below. This driver will be available in the next release of psLib.