are psArrayRemove() semantics appropriate?

[jhoblitt]

The current prototype for this function is:

bool psArrayRemove (psArray *array, const psPtr data)

But for reasons of reliablity and efficeny I think it should be:

bool psArrayRemove (psArray *array, long n)

I'm not sure if the current behavior is really useful enough to be kept.

[jhoblitt]

Is there any reason why I can't make this change? I can only see 3 places
inside of psLib where it's used and one one of these instances is a great
example of how unworkable the current API is.

if(!psArrayRemove(levelArray,levelArray->data[*level]))

[eugene]

i don't see any reason not to make this change. it is used within pxTools as
well, but I'm guessing you know that.

[jhoblitt]

I haven't used it anywhere because the API is so nasty. I'll go ahead and fix it.

[jhoblitt]

I've added a psArrayRemoveByPos() as there are actually a couple of cases where
psArrayRemove()'s current semtanitcs make sense. I think you could argue that
psArrayRemoveByPos() should be named psArrayRemove() and the current
psArrayRemove() named psArrayRemoveByPtr() as better huffman encoding but that's
really starting to split hairs.