Changeset 40932 for branches/ipp-259_genericise_backups/tools/backups/backup_test.py

Timestamp:

Oct 9, 2019, 2:15:34 PM (7 years ago)

Author:

fairlamb

Message:

Added local rsync to subprocess and how to handle it in backups (functionally the same as cp)

File:

• branches/ipp-259_genericise_backups/tools/backups/backup_test.py (modified) (4 diffs)

branches/ipp-259_genericise_backups/tools/backups/backup_test.py

@@ -186 +186 @@
         assert os.path.exists(expected2file)
 
-    def copy_fails_if_source_file_does_not_exist(self, tmpdir):
+    def test_copy_fails_if_source_file_does_not_exist(self, tmpdir):
         config = make_default_config(tmpdir, ['bck1', 'bck2'])
         source = os.path.join(tmpdir, "and_specific_file.jpeg")
@@ -196 +196 @@
         assert not os.path.exists(source)
         backy = Backup(config)
-        with pytest.raises(errs.SubprocessError):
+        with pytest.raises(errs.ValidationError):
             backy._run_copy()
 
-    def copy_fails_if_destination_does_not_exist(self, tmpdir):
+    def test_copy_fails_if_destination_does_not_exist(self, tmpdir):
         config = ConfigParser()
 
@@ -214 +214 @@
         assert not os.path.exists(backup_does_not_exist)
         backy = Backup(config)
-        with pytest.raises(errs.SubprocessError):
+        with pytest.raises(errs.ValidationError):
             backy._run_copy()
 
@@ -298 +298 @@
 
 
-# class TestRunningRsync():
-
-#     def test_simply_rsync(self):
-#         assert True is False
-
-#     def test_rsync_with_additional_args(self):
-#         assert True is False
+class TestRunningRsync():
+
+    def test_simple_rsync(self, tmpdir):
+        config = make_default_config(tmpdir, ['bck1', 'bck2'])
+        source = os.path.join(tmpdir, "and_specific_file.jpeg")
+        config['RSYNC'] = {'sources' : f"{source}"}
+
+        # make file to be copied
+        Path(source).touch()
+
+        backy = Backup(config)
+
+        expected1file = os.path.join(tmpdir, 'bck1', 'and_specific_file.jpeg')
+        expected2file = os.path.join(tmpdir, 'bck2', 'and_specific_file.jpeg')
+        assert not os.path.exists(expected1file)
+        assert not os.path.exists(expected2file)
+        backy._run_rsync()
+        assert os.path.exists(expected1file)
+        assert os.path.exists(expected2file)
+
+    def test_rsync_with_additional_args(self, tmpdir):
+        config = make_default_config(tmpdir, ['bck1', 'bck2'])
+        source1 = os.path.join(tmpdir, "some_dir")
+        source2 = os.path.join(tmpdir, "and_specific_file.jpeg")
+        config['RSYNC'] = \
+        { 'sources' : f"{source1}, {source2}"
+        , 'additional_args' : "-v -z -r --progress"
+        }
+
+        os.makedirs(source1)
+        Path(source2).touch()
+
+        backy = Backup(config)
+
+        expected1dir  = os.path.join(tmpdir, 'bck1', 'some_dir')
+        expected1file = os.path.join(tmpdir, 'bck1', 'and_specific_file.jpeg')
+        expected2dir  = os.path.join(tmpdir, 'bck2', 'some_dir')
+        expected2file = os.path.join(tmpdir, 'bck2', 'and_specific_file.jpeg')
+        assert not os.path.exists(expected1dir)
+        assert not os.path.exists(expected1file)
+        assert not os.path.exists(expected2dir)
+        assert not os.path.exists(expected2file)
+        backy._run_rsync()
+        assert os.path.exists(expected1dir)
+        assert os.path.exists(expected1file)
+        assert os.path.exists(expected2dir)
+        assert os.path.exists(expected2file)
+
+    def test_rsync_fails_if_source_file_does_not_exist(self, tmpdir):
+        config = make_default_config(tmpdir, ['bck1', 'bck2'])
+        source = os.path.join(tmpdir, "and_specific_file.jpeg")
+        config['RSYNC'] = \
+        { 'sources' : f"{source}"
+        , 'additional_args' : '-r'
+        }
+
+        assert not os.path.exists(source)
+        backy = Backup(config)
+        with pytest.raises(errs.ValidationError):
+            backy._run_rsync()
+
+    def test_rsync_fails_if_destination_does_not_exist(self, tmpdir):
+        config = ConfigParser()
+
+        backup_does_not_exist = os.path.join(tmpdir, 'does_not_exist')
+
+        config['DEFAULT'] = \
+        { 'backup_paths' : backup_does_not_exist
+        , 'source_machine': socket.gethostname()
+        }
+        source = os.path.join(tmpdir, "and_specific_file.jpeg")
+        Path(source).touch()
+        config['RSYNC'] = {'sources' : f"{source}"}
+
+        assert not os.path.exists(backup_does_not_exist)
+        backy = Backup(config)
+        with pytest.raises(errs.ValidationError):
+            backy._run_rsync()
+
+    def test_rsync_requires_dash_r_arg_for_copying_dirs(self, tmpdir):
+        config = make_default_config(tmpdir, ['bck1', 'bck2'])
+        source = os.path.join(tmpdir, "some_dir")
+        config['RSYNC'] = \
+        { 'sources' : f"{source}"
+        }
+        os.makedirs(source)
+
+        backy = Backup(config)
+        expected1dir  = os.path.join(tmpdir, 'bck1', 'some_dir')
+        expected2dir  = os.path.join(tmpdir, 'bck2', 'some_dir')
+        assert not os.path.exists(expected1dir)
+        assert not os.path.exists(expected2dir)
+        backy._run_rsync()
+        assert not os.path.exists(expected1dir)
+        assert not os.path.exists(expected2dir)
+
+        config['RSYNC'] = \
+        { 'sources' : f"{source}"
+        , 'additional_args' : '-r'
+        }
+
+        backy = Backup(config)
+        expected1dir  = os.path.join(tmpdir, 'bck1', 'some_dir')
+        expected2dir  = os.path.join(tmpdir, 'bck2', 'some_dir')
+        assert not os.path.exists(expected1dir)
+        assert not os.path.exists(expected2dir)
+        backy._run_rsync()
+        assert os.path.exists(expected1dir)
+        assert os.path.exists(expected2dir)