Changeset 40937 for branches/ipp-259_genericise_backups/tools/backups/backup_test.py

Timestamp:

Oct 11, 2019, 3:49:23 PM (7 years ago)

Author:

fairlamb

Message:

Split atlassian backups out into distinct jira & conf. Testing moved into either backups, or inherited classes

File:

• branches/ipp-259_genericise_backups/tools/backups/backup_test.py (modified) (6 diffs)

branches/ipp-259_genericise_backups/tools/backups/backup_test.py

@@ -27 +27 @@
     source_machine = socket.gethostname()
     config['DEFAULT'] = \
-    {
-        'backup_paths'   : backup_paths,
-        'source_machine' : source_machine,
-        'verbose'        : verbose,
-    }
+        { 'backup_paths'   : backup_paths
+        , 'source_machine' : source_machine
+        , 'verbose'        : verbose
+        }
     return config
 
@@ -107 +106 @@
             Backup(config_file=config)
 
-        with pytest.raises(errs.ConfigError):
+        with pytest.raises(errs.ValidationError):
             Backup(config_file=None)
 
@@ -136 +135 @@
         backy.default_dict['source_machine'] = actual_hostname
         assert backy.hostname_is_valid() is True
+
+
+class TestFilepathVerifications(object):
+
+    def test_default_target_paths_do_not_exist_in_testing(self):
+        backy = Backup(config_file=TEST_DEFAULT_CONFIG_FILE)
+        assert backy.target_backup_paths_ok() is False
+
+    def test_raising_an_error_if_a_backup_path_does_not_exist(self):
+        with pytest.raises(errs.ValidationError) as e:
+            backy = Backup(config_file=TEST_DEFAULT_CONFIG_FILE)
+            backy.target_backup_paths_ok(raise_error=True)
+        assert "ValidationError: target path does not exist" in str(e)
+
+    def test_an_incorrect_path_then_correct_path(self, tmpdir):
+        backy = Backup(config_file=TEST_DEFAULT_CONFIG_FILE)
+
+        backy.default_dict['backup_paths'] = ["/not/real/path"]
+        assert backy.target_backup_paths_ok() is False
+
+        backy.default_dict['backup_paths'] = [tmpdir]
+        assert backy.target_backup_paths_ok() is True
+
+    def test_backup_paths_created_if_make_dirs_given(self, tmpdir):
+        config = ConfigParser()
+        config['DEFAULT'] = \
+            { 'backup_paths'   : f"{tmpdir}/bck1/bobby/backup, {tmpdir}/bck2"
+            , 'source_machine' : 'rocket'
+            , 'verbose'        : 'True'
+            }
+        bck1_path   = os.path.join(tmpdir, 'bck1')
+        bck1b_path  = os.path.join(tmpdir, 'bck1/bobby')
+        bck1bb_path = os.path.join(tmpdir, 'bck1/bobby/backup')
+        bck2_path   = os.path.join(tmpdir, 'bck2')
+        assert not os.path.exists(bck1_path)
+        assert not os.path.exists(bck1b_path)
+        assert not os.path.exists(bck1bb_path)
+        assert not os.path.exists(bck2_path)
+        # backup dirs not created automatically
+        Backup(config)
+        assert not os.path.exists(bck1_path)
+        assert not os.path.exists(bck1b_path)
+        assert not os.path.exists(bck1bb_path)
+        assert not os.path.exists(bck2_path)
+
+        # make_dirs included in config - when loaded dirs created.
+        config['DEFAULT'] = \
+            { 'backup_paths'   : f"{tmpdir}/bck1/bobby/backup, {tmpdir}/bck2"
+            , 'source_machine' : 'rocket'
+            , 'verbose'        : 'True'
+            , 'make_dirs'      : 'True'
+            }
+        backy = Backup(config)
+        assert backy.default_dict['make_dirs'] is True
+        assert os.path.exists(bck1_path)
+        assert os.path.exists(bck1b_path)
+        assert os.path.exists(bck1bb_path)
+        assert os.path.exists(bck2_path)
 
 
@@ -265 +322 @@
         assert not os.path.exists(expected_tar1)
         backy._run_tar()
-        print(expected_tar1)
         assert os.path.exists(expected_tar1)
 
@@ -422 +478 @@
 """
 
-    dumper_password = "not_a_real_password"
-
     def test_mysql_dump_is_ok(self, tmpdir):
         config = make_default_config(tmpdir, ['bck1', 'bck2'])
@@ -442 +496 @@
         assert not os.path.exists(expected_dump1)
         assert not os.path.exists(expected_dump2)
-        backy._run_mysqldump()
+        result = backy._run_mysqldump()
         assert os.path.exists(expected_dump1)
         assert os.path.exists(expected_dump2)
+
+        assert result == 0
 
     def test_mysql_dump_fails_with_incorrect_password(self, tmpdir):