IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 21 years ago

Closed 21 years ago

Last modified 21 years ago

#313 closed enhancement (fixed)

PS_META_* and PS_TYPE_*

Reported by: robert.desonia@… Owned by: eugene
Priority: high Milestone:
Component: PSLib SDRS Version: unspecified
Severity: minor Keywords:
Cc:

Description

There seems to be a some parallel concepts between the PS_META_* and PS_TYPE_*
enums.

I suggest that the PS_META_* values with the PS_TYPE_* parallel values be equal
so that they could be used interchangeably without introducing an error. Doing
so negates the usefullness of the MS_META_NTYPE enum value, so I'd like to
eliminate the PS_META_NTYPE enum value and set PS_META_[S32,F32,F64,BOOL] equal
to the PS_TYPE equivalent. To be specific:

typedef enum {

PS_META_S32 = PS_TYPE_S32, /< psS32 primitive data.
PS_META_F32 = PS_TYPE_F32,
/< psF32 primitive data.
PS_META_F64 = PS_TYPE_F64, /< psF64 primitive data.
PS_META_BOOL = PS_TYPE_BOOL,
/< psBool primitive data.
PS_META_LIST = PS_TYPE_PTR+1, /< List data (Stored as

item.data.list).

PS_META_STR, /< String data (Stored as

item.data.V).

PS_META_VEC, /< Vector data (Stored as

item.data.V).

PS_META_IMG, /< Image data (Stored as item.data.V).
PS_META_HASH,
/< Hash data (Stored as item.data.V).
PS_META_LOOKUPTABLE, /< Lookup table data (Stored as

item.data.V).

PS_META_JPEG, /< JPEG data (Stored as item.data.V).
PS_META_PNG,
/< PNG data (Stored as item.data.V).
PS_META_ASTROM, /< Astrometric coefficients (Stored as

item.data.V).

PS_META_UNKNOWN

} psMetadataType;

-rdd

Change History (4)

comment:1 by Paul Price, 21 years ago

Owner: changed from Paul Price to eugene

comment:2 by eugene, 21 years ago

Status: newassigned

this solution is looking better. the point of constructing the primitive type
vs the generic PS_META_TYPE was to have only one place were the primitive types
were defined (PS_TYPE). but I agree: this solution ended up being clumsy. what
I want to have is PS_TYPE defining allowed MATH types, so I don't like have
PS_PTR in that list (as per the SDRS). so we need to clean up this particular
issue as well.

comment:3 by robert.desonia@…, 21 years ago

Resolution: fixed
Status: assignedclosed

I think this is now covered sufficiently in the code. I removed PS_TYPE_PTR, as
it is not a MATH type (in post rel5 CVS). I left PS_TYPE_BOOL in because it is
still in the SDRS (v13), but one could argue that is not a MATH type in the same
sense as the others.

-rdd

comment:4 by Paul Price, 21 years ago

psMetadata stuff is updated in the latest version of the SDRS. Reopen this bug
if the problem is not resolved there.

Note: See TracTickets for help on using tickets.