psMetadataIteratorAlloc and Mutable parameter

[robert.desonia@…]

Since psMetadata is formed from a psList and psHash containing duplicate set of
references of psMetadataItem objects, making a mutable iterator over just the
psList seems to be very dangerous as it opens up a reasonable means to add
something to the psList and not the psHash. I suggest that mutable be dropped
from the psMetadataIteratorAlloc parameter list and the return psListIterator
be set to be not mutable.

psListIterator* psMetadataIteratorAlloc(psMetadata* md, psS32 location)
{

if (md == NULL) {

return NULL;

}

return psListIteratorAlloc(md->list,location,false);

}

-rdd

[robert.desonia@…]

additionally, see bug 315 comments.

[eugene]

this solution seems fine to me.

[robert.desonia@…]

Bug 315 negates this, as it defines a new prototype for psMetadataIteratorAlloc.