#453 closed defect (fixed)
psImageTransform's use of the out parameter inconsistant
| Reported by: | Owned by: | Paul Price | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | PSLib SDRS | Version: | unspecified |
| Severity: | normal | Keywords: | |
| Cc: |
Description
With most functions, the out parameter is just supplied to allow recycling of a
data item like psImage, but for psImageTransform, that is not the case
If the out parameter is not NULL, its size is used instead of the input
psRegion, otherwise the psRegion defines the size of the output psImage. This
seems to have a different flavour compared to such functions like psImageCut or
psImageSlice, which also use psRegion to define the dimensions of the output image.
Is this intentional? Is there a problem making it this facet of behaviour
conform more to the rest of the psImage functions that take an output parameter?

This was intentional, but now I see that it really doesn't matter. Back when I
could pass in a pointer to a psRegion, I had the option of specifying one of
them as NULL (a small convenience). As it is now (pass psRegion by value), I
always have to specify a region, so we may as well use that as the size.
SDRS modified appropriately:
Transform the \code{input} image according the supplied
transformation. The size of the transformed image is defined by the
\code{region} (size \code{region.x1 - region.x0} by \code{region.y1 -
region.y0}, with \code{out->x0 = region.x0} and \code{out->y0 =
region.y0}).